-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aligned-types-hip and egs-hip : align types broken in ChipStar #46
Conversation
Thank you for the pull request. Which version of HIP is installed on your end? I don't see any compilation issue with 5.4.0 |
@zjin-lcf - Thanks for the review. hipcc is ChipStar (https://github.com/CHIP-SPV/chipStar.git) in this case. |
I will not update the program because it can be compiled without error with HIPCC on AMD GPUs. Thanks. |
Thanks for the update I will follow up on CHIP-SPV/chipStar#593 CHIP-SPV/chipStar#484 |
@zjin-lcf Please reopen this this PR as it is yet to be resolved by ChipStar team. |
I found that egs-hip is also facing same issue, hipcc -std=c++14 -Wall -O3 -c main.cu -o main.o |
This PR fixes compilation issue related to aligned-types
Compile errors:
hipcc -std=c++14 -Wall -g -O3 -c main.cu -o main.o
main.cu:65:26: error: expected unqualified-id
typedef struct align(4)
^
main.cu:65:26: error: expected ')'
main.cu:65:25: note: to match this '('
typedef struct align(4)
^
main.cu:69:1: error: a type specifier is required for all declarations
uchar4_aligned;
^
main.cu:73:26: error: expected unqualified-id
typedef struct align(8)
^
main.cu:73:26: error: expected ')'
main.cu:73:25: note: to match this '('
typedef struct align(8)